toddmeng-db commented on code in PR #3140:
URL: https://github.com/apache/arrow-adbc/pull/3140#discussion_r2205971930
##########
csharp/src/Drivers/Databricks/DatabricksSchemaParser.cs:
##########
@@ -40,8 +64,8 @@ public override IArrowType GetArrowType(TPrimitiveTypeEntry
thriftType, DataType
TTypeId.SMALLINT_TYPE => Int16Type.Default,
Review Comment:
Looks like this needs to stay as Timestamp_type, String actually does not
work for that.
```
case TType.TIMESTAMP_TYPE if SQLConf.get.arrowThriftTimestampToString =>
ArrowType.Utf8.INSTANCE
case TType.TIMESTAMP_TYPE =>
new ArrowType.Timestamp(TimeUnit.MICROSECOND, timeZoneId)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
