friendlymatthew commented on code in PR #7943:
URL: https://github.com/apache/arrow-rs/pull/7943#discussion_r2211549323
##########
parquet-variant/src/builder.rs:
##########
@@ -252,7 +304,28 @@ impl ValueBuffer {
variant: Variant<'m, 'd>,
metadata_builder: &mut MetadataBuilder,
) {
- self.try_append_variant(variant, metadata_builder).unwrap();
+ match variant {
+ Variant::Null => self.append_null(),
+ Variant::BooleanTrue => self.append_bool(true),
+ Variant::BooleanFalse => self.append_bool(false),
+ Variant::Int8(v) => self.append_int8(v),
+ Variant::Int16(v) => self.append_int16(v),
+ Variant::Int32(v) => self.append_int32(v),
+ Variant::Int64(v) => self.append_int64(v),
+ Variant::Date(v) => self.append_date(v),
+ Variant::TimestampMicros(v) => self.append_timestamp_micros(v),
+ Variant::TimestampNtzMicros(v) =>
self.append_timestamp_ntz_micros(v),
+ Variant::Decimal4(decimal4) => self.append_decimal4(decimal4),
+ Variant::Decimal8(decimal8) => self.append_decimal8(decimal8),
+ Variant::Decimal16(decimal16) => self.append_decimal16(decimal16),
+ Variant::Float(v) => self.append_float(v),
+ Variant::Double(v) => self.append_double(v),
+ Variant::Binary(v) => self.append_binary(v),
+ Variant::String(s) => self.append_string(s),
+ Variant::ShortString(s) => self.append_short_string(s),
+ Variant::Object(obj) => self.append_object(metadata_builder, obj),
+ Variant::List(list) => self.append_list(metadata_builder, list),
+ }
Review Comment:
It is unfortunate to have to copy the same match statement as
`try_append_variant`, but `ValueBuffer::append_object` and
`ValueBuffer::try_append_object` call different iterators and append methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
