kou commented on code in PR #47042:
URL: https://github.com/apache/arrow/pull/47042#discussion_r2211681432
##########
cpp/cmake_modules/SetupCxxFlags.cmake:
##########
@@ -159,6 +159,9 @@ set(CMAKE_POSITION_INDEPENDENT_CODE
${ARROW_POSITION_INDEPENDENT_CODE})
set(UNKNOWN_COMPILER_MESSAGE
"Unknown compiler: ${CMAKE_CXX_COMPILER_ID} ${CMAKE_CXX_COMPILER_VERSION}")
+# Compiler flags used when building Arrow libraries (but not tests, utilities,
etc.)
+set(LIBARROW_CXX_FLAGS)
Review Comment:
How about renaming this to `ARROW_LIBRARY_ONLY_CXX_FLAGS` or something?
* We want to use `ARROW_` prefix for our variables
* I feel that `LIBARROW` means only for `libarrow.so` but this is for not
only `libarrow.so` but also other libraries such as `libparquet.so`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
