westonpace commented on a change in pull request #9947:
URL: https://github.com/apache/arrow/pull/9947#discussion_r611938754
##########
File path: cpp/src/arrow/dataset/test_util.h
##########
@@ -136,6 +138,15 @@ class DatasetFixtureMixin : public ::testing::Test {
}
}
+ /// \brief Ensure a record batch yielded by the fragment matches the next
batch yielded
+ /// by the reader
+ void AssertBatchEquals(RecordBatchReader* expected, RecordBatch* batch) {
Review comment:
Done. Although why isn't `RecordBatchReader` passed by reference? Is
it simply the fact that `RecordBatch` is `const`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
