jackyhu-db commented on PR #3175:
URL: https://github.com/apache/arrow-adbc/pull/3175#issuecomment-3090431479
> This change will obviously work, but I think it's pretty confusing. Can we
instead put a `virtual int DefaultQueryTimeoutSeconds { get; } on
`Hive2Connection` and then override it from DatabricksConnection?
>
> (Feel free to push back; I don't feel super strongly about it.)
I am not sure if this change will work as the `QueryTimeoutSeconds` is set
in the base class `Hive2ServerConnection`, at this time it does not get the
value `DefaultQueryTimeoutSeconds` from the subclass `DatabricksConnection`.
The logic I added here is it will set the `QueryTimeoutSeconds` with 3 hours as
long as it is not customized by the client. Which means even if it is
configured by the base class with some other logic, it will still be
overwritten with 3 hours.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
