thisisnic commented on PR #46878: URL: https://github.com/apache/arrow/pull/46878#issuecomment-3092609585
In general, the PR looks great; would want to give it a more in-depth review before merging, but this is the right shape of how it should look. This has me thinking a bit about the bigger picture - this one function is useful, but I wonder if having just one data.table function might be a little awkward / folks might be looking for more like this. A few thoughts: - What other data.table functions would we need to add to make this meaningfully useful for people who want data.table/arrow interop? It'd be great to understand that a little better first. - If we do decide to support more functions, would you or others be interested in submitting PRs for those? - We already have a lot in the R package, i.e. all our bindings for dplyr and chunks of the tidyverse. If we're adding more code to maintain, would we want to consider a separate package, as per dtplyr or keep it here? If anyone was working on #39822, it feels like it would fit in better there, but I don't believe folks are, so here is probably the most sensible location. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
