klion26 commented on code in PR #7935:
URL: https://github.com/apache/arrow-rs/pull/7935#discussion_r2218042453
##########
parquet-variant/src/builder.rs:
##########
@@ -1000,6 +1048,8 @@ impl<'a> ListBuilder<'a> {
// Get parent's buffer
let parent_buffer = self.parent_state.buffer();
+ // as object builder has been reused the parent buffer,
+ // we need to shift the offset by the starting offset of the parent
object
Review Comment:
Good catch, because if we create a `ListBuilder` inside an `ObjectBuilder`,
then we need do this shift, but after the last change, the comment here need to
be moved to `ParentState::finish()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
