carpecodeum commented on PR #7946: URL: https://github.com/apache/arrow-rs/pull/7946#issuecomment-3096716039
> Partial review. > > The overriding takeaway for me (which got in the way of reviewing the actual PR functionality) is that this PR has a dangerously high level of code duplication vs. existing code in the parquet-variant crate. Dangerous because it includes many bugs and inefficiencies that the other code already solved (which is ~inevitable with such a high amount of redundancy). > > Can we please take the time to harmonize with existing code so reviewers can focus on the really important and exciting net new functionality instead of debugging a reinvented wheel? Hi @scovich yes, currently this is still in progress, which essentially means that I am still working on removing the redundancy, its just taking a bit more time than I thought for me because I had to focus on some other stuff the past few days, I still have it in draft as to just make sure people dont confuse it as a ready-to-go PR, but thanks for this review its very helpful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
