zeroshade commented on code in PR #3180: URL: https://github.com/apache/arrow-adbc/pull/3180#discussion_r2220023766
########## docs/source/format/driver_manifests.rst: ########## @@ -335,33 +341,40 @@ to control which directories will be searched for manifests, with the behavior b The ``ManagedDriver`` type has a method ``load_dynamic_from_name`` which takes an optional ``load_flags`` parameter. The flags as a ``u32`` with the type ``adbc_core::driver_manager::LoadFlags``, which has the following constants: - * `LOAD_FLAG_SEARCH_ENV` - search the environment variable ``ADBC_CONFIG_PATH`` - * `LOAD_FLAG_SEARCH_USER` - search the user configuration directory - * `LOAD_FLAG_SEARCH_SYSTEM` - search the system configuration directory - * `LOAD_FLAG_ALLOW_RELATIVE_PATHS` - allow a relative path to be used - * `LOAD_FLAG_DEFAULT` - default value with all flags set -For unix-like platforms, (e.g. Linux, macOS), the driver manager will search the following directories based on the options provided, in + * ``LOAD_FLAG_SEARCH_ENV`` - search the environment variable ``ADBC_CONFIG_PATH`` + * ``LOAD_FLAG_SEARCH_USER`` - search the user configuration directory + * ``LOAD_FLAG_SEARCH_SYSTEM`` - search the system configuration directory + * ``LOAD_FLAG_ALLOW_RELATIVE_PATHS`` - allow a relative path to be used + * ``LOAD_FLAG_DEFAULT`` - default value with all flags set + +Unix-like Platforms +^^^^^^^^^^^^^^^^^^^ + +For Unix-like platforms, (e.g. Linux, macOS), the driver manager will search the following directories based on the options provided, in the given order: #. If the ``LOAD_FLAG_SEARCH_ENV`` load option is set, then the environment variable ``ADBC_CONFIG_PATH`` will be searched - * ``ADBC_CONFIG_PATH`` is a colon-separated list of directories to search for ``${name}.toml`` Review Comment: why remove the bullet? This was intended to be a sub-bullet point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org