andishgar commented on code in PR #47149:
URL: https://github.com/apache/arrow/pull/47149#discussion_r2221361325
##########
cpp/src/arrow/record_batch_test.cc:
##########
@@ -142,6 +142,94 @@ TEST_F(TestRecordBatch, ApproxEqualOptions) {
EXPECT_TRUE(b1->ApproxEquals(*b2, options));
}
+class TestRecordBatchEqualsSameAddress : public TestRecordBatch {};
+
+TEST_F(TestRecordBatchEqualsSameAddress, NonFloatType) {
+ auto f0 = field("f0", int32());
+ auto f1 = field("f1", int64());
+
+ auto schema = ::arrow::schema({f0, f1});
+
+ auto a0 = ArrayFromJSON(f0->type(), "[0, 1, 2]");
+ auto a1 = ArrayFromJSON(f1->type(), "[0, 1, 2]");
+
+ auto b0 = RecordBatch::Make(schema, 3, {a0, a1});
+ auto b1 = b0;
+
+ auto options = EqualOptions::Defaults();
+
+ ASSERT_TRUE(b0->Equals(*b1, true, options));
+ ASSERT_TRUE(b0->Equals(*b1, true, options.nans_equal(true)));
+
+ ASSERT_TRUE(b0->ApproxEquals(*b1, options));
+ ASSERT_TRUE(b0->ApproxEquals(*b1, options.nans_equal(true)));
+}
+
+TEST_F(TestRecordBatchEqualsSameAddress, NestedTypesWithoutFloat) {
Review Comment:
It's okay, I will apply it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
