raulcd commented on code in PR #46992:
URL: https://github.com/apache/arrow/pull/46992#discussion_r2222133585
##########
cpp/src/parquet/statistics.h:
##########
@@ -259,6 +264,14 @@ class PARQUET_EXPORT Statistics {
/// \brief Plain-encoded maximum value
virtual std::string EncodeMax() const = 0;
+ /// \brief Return the minimum value exact flag if set.
+ /// It will be true if there was no truncation.
+ virtual std::optional<bool> is_min_value_exact() const = 0;
Review Comment:
Similar to my comments on the printer, I'll let the other Parquet committers
and PMC discuss but imho we should be explicit, this matches the Parquet spec
as the underlying Thrift fields are optional so we should expose that
optionality. I had a previous implementation with `virtual bool
is_min_value_exact() const = 0;` but I also had the corresponding `virtual bool
HasIsMinValueExact() const = 0;`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
