alamb commented on code in PR #7935:
URL: https://github.com/apache/arrow-rs/pull/7935#discussion_r2222151341
##########
parquet-variant/src/builder.rs:
##########
@@ -1118,8 +1181,8 @@ impl<'a> ObjectBuilder<'a> {
/// Finalizes this object and appends it to its parent, which otherwise
remains unmodified.
pub fn finish(mut self) -> Result<(), ArrowError> {
- let metadata_builder = self.parent_state.metadata_builder();
if self.validate_unique_fields && !self.duplicate_fields.is_empty() {
+ let metadata_builder = self.parent_state.metadata_builder();
Review Comment:
I reverted this change in 19bb544be4 to keep the diff cleaner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
