alamb commented on code in PR #7967:
URL: https://github.com/apache/arrow-rs/pull/7967#discussion_r2225147331
##########
arrow-select/src/coalesce/byte_view.rs:
##########
@@ -284,7 +284,10 @@ impl<B: ByteViewType> InProgressArray for
InProgressByteViewArray<B> {
(false, 0)
} else {
let ideal_buffer_size = s.total_buffer_bytes_used();
- let actual_buffer_size = s.get_buffer_memory_size();
+ // We don't need to use get_buffer_memory_size here, because
we gc is mainly for
+ // data buffers, not views and nulls.
Review Comment:
```suggestion
// We don't use get_buffer_memory_size here, because gc is
for the contents of the
// data buffers, not views and nulls.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
