klion26 commented on code in PR #7987:
URL: https://github.com/apache/arrow-rs/pull/7987#discussion_r2227278027
##########
parquet-variant/src/builder.rs:
##########
@@ -1242,7 +1294,18 @@ impl<'a> ListBuilder<'a> {
/// This is to ensure that the list is always finalized before its parent
builder
/// is finalized.
impl Drop for ListBuilder<'_> {
- fn drop(&mut self) {}
+ fn drop(&mut self) {
Review Comment:
Verified that the `drop` for `ListBuilder` was covered with `cargo llvm-cov
--html test -p parquet-variant`
<img width="718" height="349" alt="image"
src="https://github.com/user-attachments/assets/4f7dd4f5-a3a6-41f5-b443-3e8fc1612f5a"
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]