sahil1105 commented on a change in pull request #9996:
URL: https://github.com/apache/arrow/pull/9996#discussion_r612367507
##########
File path: python/pyarrow/_s3fs.pyx
##########
@@ -45,6 +45,98 @@ def finalize_s3():
check_status(CFinalizeS3())
+cdef class S3ProxyOptions:
+ """
+ Proxy Options for S3
+
+ Parameters
+ ----------
+
+ scheme : str, default ''
+ Proxy scheme. Valid values: 'http' and 'https'.
Review comment:
I think we want it to remain empty in the default case where we aren't
using a proxy. I'll have to verify, but I think otherwise the AWS SDK might try
to use a proxy and fail.
Also
[this](https://github.com/aws/aws-sdk-cpp/blob/e4223509ba1bcc5807dfb4f1afef01fdc83ad8c2/aws-cpp-sdk-core/include/aws/core/client/ClientConfiguration.h#L130)
doesn't specify a default, unlike
[this](https://github.com/aws/aws-sdk-cpp/blob/e4223509ba1bcc5807dfb4f1afef01fdc83ad8c2/aws-cpp-sdk-core/include/aws/core/client/ClientConfiguration.h#L66).
But since we're getting rid of this class it shouldn't matter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
