amoeba commented on code in PR #47181:
URL: https://github.com/apache/arrow/pull/47181#discussion_r2228928165
##########
dev/release/post-05-update-gh-release-notes.sh:
##########
@@ -20,21 +20,23 @@
set -e
set -o pipefail
+SOURCE_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+
if [ "$#" -ne 1 ]; then
echo "Usage: $0 <version>"
exit 1
fi
+. "${SOURCE_DIR}/utils-env.sh"
VERSION=$1
REPOSITORY="apache/arrow"
TAG="apache-arrow-${VERSION}"
WORKFLOW="release.yml"
-SOURCE_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
# Wait for the GitHub Workflow that creates the GitHub Release
# to finish before updating the release notes.
-. $SOURCE_DIR/utils-watch-gh-workflow.sh ${TAG} ${WORKFLOW}
+$SOURCE_DIR/utils-watch-gh-workflow.sh ${TAG} ${WORKFLOW}
Review Comment:
Can this benefit from quotes?
```suggestion
"$SOURCE_DIR/utils-watch-gh-workflow.sh" "${TAG}" "${WORKFLOW}"
```
##########
dev/release/utils-env.sh:
##########
@@ -0,0 +1,29 @@
+# shellcheck shell=bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+SOURCE_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+
+if [ ! -f "${SOURCE_DIR}/.env" ]; then
+ echo "You must create ${SOURCE_DIR}/.env"
+ echo "You can use ${SOURCE_DIR}/.env.example as template"
+ exit 1
+fi
+# shellcheck source=SCRIPTDIR/.env.example
+. ${SOURCE_DIR}/.env
Review Comment:
```suggestion
. "${SOURCE_DIR}/.env"
```
##########
dev/merge_arrow_pr.py:
##########
@@ -254,10 +255,13 @@ def __init__(self, project_name, cmd):
config = load_configuration()
if "github" in config.sections():
token = config["github"]["api_token"]
+ if not token:
+ token = os.environ.get('GH_TOKEN')
if not token:
Review Comment:
Do we want to warn people they're still using `ARROW_GITHUB_API_TOKEN` to
allow us to fully deprecate it at some point?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
