ff-kamal commented on PR #47178:
URL: https://github.com/apache/arrow/pull/47178#issuecomment-3115097736
I've added a unit test to test out the various ways of calling this method.
> Luckily it only causes issue when the user calls .from_uri() on an actual
filesystem instance:
Unfortunately, this change also causes it to break when calling it as a
class method, but only when you explicitly specify the input parameter:
```python
>>> from pyarrow.fs import FileSystem
# This is fine
>>> FileSystem.from_uri("s3://abc")
(<pyarrow._s3fs.S3FileSystem object at 0x101e54330>, 'abc')
# This breaks
>>> FileSystem.from_uri(uri="s3://abc")
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: from_uri() needs an argument
```
Which I believe has to do how Python expects that first instance method
argument (`self` usually) to be positional, but not entirely sure.
I'll update the original description to point out the two ways this fails
currently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
