zanmato1984 commented on code in PR #47129:
URL: https://github.com/apache/arrow/pull/47129#discussion_r2229989002
##########
cpp/src/arrow/dataset/dataset_writer_test.cc:
##########
@@ -275,6 +276,38 @@ TEST_F(DatasetWriterTestFixture,
BatchGreaterThanMaxRowsQueued) {
ASSERT_EQ(paused_, false);
}
+TEST_F(DatasetWriterTestFixture, BatchWriteConcurrent) {
Review Comment:
```suggestion
TEST_F(DatasetWriterTestFixture, BatchWriteConcurrent) {
#ifndef ARROW_ENABLE_THREADING
GTEST_SKIP() << "Test requires threading support";
#endif
```
##########
cpp/src/arrow/dataset/dataset_writer_test.cc:
##########
@@ -275,6 +276,38 @@ TEST_F(DatasetWriterTestFixture,
BatchGreaterThanMaxRowsQueued) {
ASSERT_EQ(paused_, false);
}
+TEST_F(DatasetWriterTestFixture, BatchWriteConcurrent) {
Review Comment:
How long does this case run?
##########
cpp/src/arrow/dataset/dataset_writer_test.cc:
##########
@@ -275,6 +276,38 @@ TEST_F(DatasetWriterTestFixture,
BatchGreaterThanMaxRowsQueued) {
ASSERT_EQ(paused_, false);
}
+TEST_F(DatasetWriterTestFixture, BatchWriteConcurrent) {
Review Comment:
We should skip the test under non-threading build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
