andishgar commented on code in PR #47183:
URL: https://github.com/apache/arrow/pull/47183#discussion_r2230590724
##########
cpp/src/arrow/compare.cc:
##########
@@ -1532,11 +1533,14 @@ bool DoubleEquals(const double& left, const double&
right, const EqualOptions& o
return result;
}
-bool ArrayStatisticsValueTypeEquals(
- const std::optional<ArrayStatistics::ValueType>& left,
- const std::optional<ArrayStatistics::ValueType>& right, const
EqualOptions& options) {
+template <typename Type>
+bool ArrayStatisticsValueTypeEquals(const std::optional<Type>& left,
Review Comment:
My suggestion is to change it to ArrayStatisticsValueEquals. Do you think
this is better? I agree that my initial name was misleading
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
