alamb commented on code in PR #7850:
URL: https://github.com/apache/arrow-rs/pull/7850#discussion_r2231641124
##########
parquet/src/arrow/async_reader/mod.rs:
##########
@@ -1832,6 +1882,7 @@ mod tests {
assert_eq!(total_rows, 730);
}
+ #[ignore]
Review Comment:
@XiangpengHao what do you suggest we do with this test?
##########
parquet/src/arrow/async_reader/mod.rs:
##########
@@ -597,11 +610,16 @@ where
metadata: self.metadata.as_ref(),
};
+ let cache_options_builder =
Review Comment:
Update: @XiangpengHao and I think it is not worth integrating the cache into
the sync reader as the cache would have to cache *all* the rows across all row
groups which is likely not very useful in practice. We'll instead focus on a
more flexible Push Decode #7983
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
