liamzwbao commented on code in PR #7984:
URL: https://github.com/apache/arrow-rs/pull/7984#discussion_r2233428107
##########
arrow-array/src/builder/generic_bytes_builder.rs:
##########
@@ -67,8 +67,8 @@ impl<T: ByteArrayType> GenericByteBuilder<T> {
value_buffer: MutableBuffer,
null_buffer: Option<MutableBuffer>,
) -> Self {
- let offsets_builder =
BufferBuilder::<T::Offset>::new_from_buffer(offsets_buffer);
- let value_builder = BufferBuilder::<u8>::new_from_buffer(value_buffer);
+ let offsets_builder =
Vec::from(offsets_buffer.typed_data::<T::Offset>());
+ let value_builder = Vec::from(value_buffer.as_slice());
Review Comment:
Replace it with ScalarBuffer instead
##########
arrow-array/src/builder/generic_bytes_builder.rs:
##########
@@ -67,8 +67,8 @@ impl<T: ByteArrayType> GenericByteBuilder<T> {
value_buffer: MutableBuffer,
null_buffer: Option<MutableBuffer>,
) -> Self {
- let offsets_builder =
BufferBuilder::<T::Offset>::new_from_buffer(offsets_buffer);
- let value_builder = BufferBuilder::<u8>::new_from_buffer(value_buffer);
+ let offsets_builder =
Vec::from(offsets_buffer.typed_data::<T::Offset>());
+ let value_builder = Vec::from(value_buffer.as_slice());
Review Comment:
Replace it with `ScalarBuffer` instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
