WillAyd commented on code in PR #46647:
URL: https://github.com/apache/arrow/pull/46647#discussion_r2237916743
##########
cpp/src/parquet/stream_writer.h:
##########
@@ -234,7 +234,7 @@ class PARQUET_EXPORT StreamWriter {
static constexpr int16_t kRepLevelZero = 0;
static constexpr int64_t kBatchSizeOne = 1;
- static int64_t default_row_group_size_;
+ inline static int64_t default_row_group_size_{512 * 1024 * 1024}; // 512MB;
Review Comment:
It looks like MSVC compilers require that this member be inline static, or
else the default constructor will attempt to access it, resulting in a linker
error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
