wgtmac commented on code in PR #47190: URL: https://github.com/apache/arrow/pull/47190#discussion_r2241393935
########## cpp/src/parquet/types.h: ########## @@ -853,8 +853,9 @@ PARQUET_EXPORT std::string TypeToString(Type::type t); PARQUET_EXPORT std::string TypeToString(Type::type t, int type_length); -PARQUET_EXPORT std::string FormatStatValue(Type::type parquet_type, - ::std::string_view val); +PARQUET_EXPORT std::string FormatStatValue( + Type::type parquet_type, ::std::string_view val, + const std::shared_ptr<const LogicalType>& logical_type = NULLPTR); Review Comment: Yes, just to be consistent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
