toddmeng-db commented on code in PR #3217:
URL: https://github.com/apache/arrow-adbc/pull/3217#discussion_r2241479129
##########
csharp/src/Drivers/Databricks/CloudFetch/CloudFetchResultFetcher.cs:
##########
@@ -247,6 +247,10 @@ private async Task FetchResultsAsync(CancellationToken
cancellationToken)
_downloadQueue.Add(EndOfResultsGuard.Instance,
cancellationToken);
_isCompleted = true;
Review Comment:
I think we need to avoid this here, since it's possible that DownloadQueue
is full, then an exception would not complete. Should I modify the Exception
handling below? @jadewang-db
```
catch (Exception ex)
{
try
{
_downloadQueue.Add(EndOfResultsGuard.Instance,
CancellationToken.None);
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
