wgtmac commented on code in PR #47090:
URL: https://github.com/apache/arrow/pull/47090#discussion_r2241554410
##########
cpp/src/parquet/properties.h:
##########
@@ -155,6 +155,7 @@ class PARQUET_EXPORT ReaderProperties {
ReaderProperties PARQUET_EXPORT default_reader_properties();
static constexpr int64_t kDefaultDataPageSize = 1024 * 1024;
+static constexpr int64_t kDefaultMaxRowsPerPage = 20'000;
Review Comment:
Right, defaulting to 20000 will definitely create smaller pages of numeric
types. 20000 is also used by parquet-java and arrow-rs and considered to be a
good value per the discussion at
https://lists.apache.org/thread/vsxmbvnx9gy5414cfo25mnwcj17h1xyp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
