gitmodimo commented on code in PR #47129:
URL: https://github.com/apache/arrow/pull/47129#discussion_r2242101336
##########
cpp/src/arrow/dataset/dataset_writer_test.cc:
##########
@@ -275,6 +276,41 @@ TEST_F(DatasetWriterTestFixture,
BatchGreaterThanMaxRowsQueued) {
ASSERT_EQ(paused_, false);
}
+TEST_F(DatasetWriterTestFixture, BatchWriteConcurrent) {
Review Comment:
IIUC future is thread safe as long it is not concurrently destroyed or
overwritten . Here we always operate on copies so we are safe. Indeed the race
was logical due to invalid backpressure API. We could not reliably tell whether
current_value was actually increased.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
