trxcllnt commented on PR #225: URL: https://github.com/apache/arrow-js/pull/225#issuecomment-3146659195
Maybe I'm missing something about this PR, but this seems like the `Utf8View` just duplicates everything from `Utf8`, and doesn't actually provide a "view" over Utf8 bytes? I assume a real `Utf8View` implementation would include a scalar type that lazily decodes the bytes into a JS string on demand? If this is just duplicating the Utf8 code, we should just interpret the `Utf8View` typeId as a `Utf8` typeId and reuse all the existing codepaths. We already get complaints about library bundle size, we shouldn't add to it if it can be helped. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
