jecsand838 commented on PR #8046: URL: https://github.com/apache/arrow-rs/pull/8046#issuecomment-3156701642
@yongkyunlee Thank you for catching this bug and getting a fix for it up! I left a few nits, but LMGTM. The recommendation regarding the test should eliminate the need for the helpers and be easier to lint imo. Only other thing I'd recommend is creating an Avro file using this schema in `arrow-avro/test/data` and adding a test for it to `arrow-avro/src/reader/mod.rs`. That way we can be sure it works E2E. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
