geoffreyclaude commented on PR #432:
URL: 
https://github.com/apache/arrow-rs-object-store/pull/432#issuecomment-3160279122

   > I think this looks good to me -- thank you @m09526 
   > 
   > 
   > @geoffreyclaude and @asubiotto  are you happy with this implementation as 
well?
   
   @alamb I agree with @asubiotto that moving `instrumented-object-store` as is 
here would probably be simpler, if only because it is already validated in 
(our) production setup. Then if there are changes to do for better user 
experience or performance, we can iterate on the code.
   
   Moreover, from a quick look at this PR it seems to be missing functionality 
of `instrumented-object-store`, e.g. tracing of operation results, and the 
`get` and `put` calls?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to