ding-young commented on PR #7627: URL: https://github.com/apache/arrow-rs/pull/7627#issuecomment-3160072556
Hi @LiaCastaneda :) I just ran the reproducer test, and it passes without error on the fix-row-converter branch. <img width="1218" height="204" alt="image" src="https://github.com/user-attachments/assets/a08c40f4-84b0-48d8-a6fa-30325b929c12"; /> However, this PR takes the approach of correcting the data type, rather than preserving the original dictionary encoding. So https://github.com/apache/arrow-rs/pull/7627#discussion_r2143655781 the resulting type is flattened, like mentioned here https://github.com/apache/arrow-rs/issues/7169#issuecomment-2675211398. I can easily follow up on the minor review comments in a day, but currently I don’t have time to rewrite the decoding logic to preserve the original encoding like @alamb suggested. What kind of solution were you thinking of? If your main goal is just to suppress the warning and run the reproducer query, then I can quickly finish up this PR and ping you again. But if you’re planning to work on a solution that preserves the original dictionary encoding, feel free to take it over! Let me know what you think :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
