jecsand838 commented on code in PR #8025: URL: https://github.com/apache/arrow-rs/pull/8025#discussion_r2257936975
########## arrow-avro/benches/decoder.rs: ########## @@ -0,0 +1,436 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Benchmarks for `arrow‑avro` **Decoder** +//! + +extern crate apache_avro; +extern crate arrow_avro; +extern crate criterion; +extern crate num_bigint; +extern crate once_cell; +extern crate uuid; + +use apache_avro::types::Value; +use apache_avro::{to_avro_datum, Decimal, Schema as ApacheSchema}; +use arrow_avro::{reader::ReaderBuilder, schema::Schema as AvroSchema}; +use criterion::{criterion_group, criterion_main, BatchSize, BenchmarkId, Criterion, Throughput}; +use once_cell::sync::Lazy; +use std::{hint::black_box, io, time::Duration}; +use uuid::Uuid; + +fn encode_records(schema: &ApacheSchema, rows: impl Iterator<Item = Value>) -> Vec<u8> { + let mut out = Vec::new(); + for v in rows { + out.extend_from_slice(&to_avro_datum(schema, v).expect("encode datum failed")); + } + out +} + +fn gen_int(sc: &ApacheSchema, n: usize) -> Vec<u8> { + encode_records( + sc, + (0..n).map(|i| Value::Record(vec![("field1".into(), Value::Int(i as i32))])), + ) +} + +fn gen_long(sc: &ApacheSchema, n: usize) -> Vec<u8> { + encode_records( + sc, + (0..n).map(|i| Value::Record(vec![("field1".into(), Value::Long(i as i64))])), + ) +} + +fn gen_float(sc: &ApacheSchema, n: usize) -> Vec<u8> { + encode_records( + sc, + (0..n).map(|i| Value::Record(vec![("field1".into(), Value::Float(i as f32 + 0.5678))])), + ) +} + +fn gen_bool(sc: &ApacheSchema, n: usize) -> Vec<u8> { + encode_records( + sc, + (0..n).map(|i| Value::Record(vec![("field1".into(), Value::Boolean(i % 2 == 0))])), + ) +} + +fn gen_double(sc: &ApacheSchema, n: usize) -> Vec<u8> { + encode_records( + sc, + (0..n).map(|i| Value::Record(vec![("field1".into(), Value::Double(i as f64 + 0.1234))])), + ) +} + +fn gen_bytes(sc: &ApacheSchema, n: usize) -> Vec<u8> { + encode_records( + sc, + (0..n).map(|i| { + let payload = vec![(i & 0xFF) as u8; 16]; + Value::Record(vec![("field1".into(), Value::Bytes(payload))]) + }), + ) +} + +fn gen_string(sc: &ApacheSchema, n: usize) -> Vec<u8> { + encode_records( + sc, + (0..n).map(|i| { + let s = if i % 3 == 0 { + format!("value-{i}") + } else { + "abcdefghij".into() + }; + Value::Record(vec![("field1".into(), Value::String(s))]) + }), + ) +} + +fn gen_date(sc: &ApacheSchema, n: usize) -> Vec<u8> { + encode_records( + sc, + (0..n).map(|i| Value::Record(vec![("field1".into(), Value::Int(i as i32))])), + ) +} + +fn gen_timemillis(sc: &ApacheSchema, n: usize) -> Vec<u8> { + encode_records( + sc, + (0..n).map(|i| Value::Record(vec![("field1".into(), Value::Int((i * 37) as i32))])), + ) +} + +fn gen_timemicros(sc: &ApacheSchema, n: usize) -> Vec<u8> { + encode_records( + sc, + (0..n).map(|i| Value::Record(vec![("field1".into(), Value::Long((i * 1_001) as i64))])), + ) +} + +fn gen_ts_millis(sc: &ApacheSchema, n: usize) -> Vec<u8> { + encode_records( + sc, + (0..n).map(|i| { + Value::Record(vec![( + "field1".into(), + Value::Long(1_600_000_000_000 + i as i64), + )]) + }), + ) +} + +fn gen_ts_micros(sc: &ApacheSchema, n: usize) -> Vec<u8> { + encode_records( + sc, + (0..n).map(|i| { + Value::Record(vec![( + "field1".into(), + Value::Long(1_600_000_000_000_000 + i as i64), + )]) + }), + ) +} + +fn gen_map(sc: &ApacheSchema, n: usize) -> Vec<u8> { + use std::collections::HashMap; + encode_records( + sc, + (0..n).map(|i| { + let mut m = HashMap::new(); + let int_val = |v: i32| Value::Union(0, Box::new(Value::Int(v))); + m.insert("key1".into(), int_val(i as i32)); + let key2_val = if i % 5 == 0 { + Value::Union(1, Box::new(Value::Null)) + } else { + int_val(i as i32 + 1) + }; + m.insert("key2".into(), key2_val); + m.insert("key3".into(), int_val(42)); + Value::Record(vec![("field1".into(), Value::Map(m))]) + }), + ) +} + +fn gen_array(sc: &ApacheSchema, n: usize) -> Vec<u8> { + encode_records( + sc, + (0..n).map(|i| { + let items = (0..5).map(|j| Value::Int(i as i32 + j)).collect(); + Value::Record(vec![("field1".into(), Value::Array(items))]) + }), + ) +} + +fn trim_i128_be(v: i128) -> Vec<u8> { + let full = v.to_be_bytes(); + let first = full + .iter() + .enumerate() + .take_while(|(i, b)| { + *i < 15 + && ((**b == 0x00 && full[i + 1] & 0x80 == 0) + || (**b == 0xFF && full[i + 1] & 0x80 != 0)) + }) + .count(); + full[first..].to_vec() +} + +fn gen_decimal(sc: &ApacheSchema, n: usize) -> Vec<u8> { + encode_records( + sc, + (0..n).map(|i| { + let unscaled = if i % 2 == 0 { i as i128 } else { -(i as i128) }; + Value::Record(vec![( + "field1".into(), + Value::Decimal(Decimal::from(trim_i128_be(unscaled))), + )]) + }), + ) +} + +fn gen_uuid(sc: &ApacheSchema, n: usize) -> Vec<u8> { + encode_records( + sc, + (0..n).map(|i| { + let mut raw = (i as u128).to_be_bytes(); + raw[6] = (raw[6] & 0x0F) | 0x40; + raw[8] = (raw[8] & 0x3F) | 0x80; + Value::Record(vec![("field1".into(), Value::Uuid(Uuid::from_bytes(raw)))]) + }), + ) +} + +fn gen_fixed(sc: &ApacheSchema, n: usize) -> Vec<u8> { + encode_records( + sc, + (0..n).map(|i| { + let mut buf = vec![0u8; 16]; + buf[..8].copy_from_slice(&(i as u64).to_be_bytes()); + Value::Record(vec![("field1".into(), Value::Fixed(16, buf))]) + }), + ) +} + +fn gen_interval(sc: &ApacheSchema, n: usize) -> Vec<u8> { + encode_records( + sc, + (0..n).map(|i| { + let months = (i % 24) as u32; + let days = (i % 32) as u32; + let millis = (i * 10) as u32; + let mut buf = Vec::with_capacity(12); + buf.extend_from_slice(&months.to_le_bytes()); + buf.extend_from_slice(&days.to_le_bytes()); + buf.extend_from_slice(&millis.to_le_bytes()); + Value::Record(vec![("field1".into(), Value::Fixed(12, buf))]) + }), + ) +} + +fn gen_enum(sc: &ApacheSchema, n: usize) -> Vec<u8> { + const SYMBOLS: [&str; 3] = ["A", "B", "C"]; + encode_records( + sc, + (0..n).map(|i| { + let idx = i % 3; + Value::Record(vec![( + "field1".into(), + Value::Enum(idx as u32, SYMBOLS[idx].into()), + )]) + }), + ) +} + +fn gen_mixed(sc: &ApacheSchema, n: usize) -> Vec<u8> { + encode_records( + sc, + (0..n).map(|i| { + Value::Record(vec![ + ("f1".into(), Value::Int(i as i32)), + ("f2".into(), Value::Long(i as i64)), + ("f3".into(), Value::String(format!("name-{i}"))), + ("f4".into(), Value::Double(i as f64 * 1.5)), + ]) + }), + ) +} + +fn gen_nested(sc: &ApacheSchema, n: usize) -> Vec<u8> { + encode_records( + sc, + (0..n).map(|i| { + let sub = Value::Record(vec![ + ("x".into(), Value::Int(i as i32)), + ("y".into(), Value::String("constant".into())), + ]); + Value::Record(vec![("sub".into(), sub)]) + }), + ) +} + +const DEFAULT_BATCH: usize = 65_536; + +fn new_decoder( + schema_json: &'static str, + batch_size: usize, + utf8view: bool, +) -> arrow_avro::reader::Decoder { + let schema: AvroSchema<'static> = serde_json::from_str(schema_json).unwrap(); + ReaderBuilder::new() + .with_schema(schema) + .with_batch_size(batch_size) + .with_utf8_view(utf8view) + .build_decoder(io::empty()) + .expect("failed to build decoder") +} + +const SIZES: [usize; 3] = [100, 10_000, 1_000_000]; + +const INT_SCHEMA: &str = + r#"{"type":"record","name":"IntRec","fields":[{"name":"field1","type":"int"}]}"#; +const LONG_SCHEMA: &str = + r#"{"type":"record","name":"LongRec","fields":[{"name":"field1","type":"long"}]}"#; +const FLOAT_SCHEMA: &str = + r#"{"type":"record","name":"FloatRec","fields":[{"name":"field1","type":"float"}]}"#; +const BOOL_SCHEMA: &str = + r#"{"type":"record","name":"BoolRec","fields":[{"name":"field1","type":"boolean"}]}"#; +const DOUBLE_SCHEMA: &str = + r#"{"type":"record","name":"DoubleRec","fields":[{"name":"field1","type":"double"}]}"#; +const BYTES_SCHEMA: &str = + r#"{"type":"record","name":"BytesRec","fields":[{"name":"field1","type":"bytes"}]}"#; +const STRING_SCHEMA: &str = + r#"{"type":"record","name":"StrRec","fields":[{"name":"field1","type":"string"}]}"#; +const DATE_SCHEMA: &str = r#"{"type":"record","name":"DateRec","fields":[{"name":"field1","type":{"type":"int","logicalType":"date"}}]}"#; +const TMILLIS_SCHEMA: &str = r#"{"type":"record","name":"TimeMsRec","fields":[{"name":"field1","type":{"type":"int","logicalType":"time-millis"}}]}"#; +const TMICROS_SCHEMA: &str = r#"{"type":"record","name":"TimeUsRec","fields":[{"name":"field1","type":{"type":"long","logicalType":"time-micros"}}]}"#; +const TSMILLIS_SCHEMA: &str = r#"{"type":"record","name":"TsMsRec","fields":[{"name":"field1","type":{"type":"long","logicalType":"timestamp-millis"}}]}"#; +const TSMICROS_SCHEMA: &str = r#"{"type":"record","name":"TsUsRec","fields":[{"name":"field1","type":{"type":"long","logicalType":"timestamp-micros"}}]}"#; +const MAP_SCHEMA: &str = r#"{"type":"record","name":"MapRec","fields":[{"name":"field1","type":{"type":"map","values":["int","null"]}}]}"#; +const ARRAY_SCHEMA: &str = r#"{"type":"record","name":"ArrRec","fields":[{"name":"field1","type":{"type":"array","items":"int"}}]}"#; +const DECIMAL_SCHEMA: &str = r#"{"type":"record","name":"DecRec","fields":[{"name":"field1","type":{"type":"bytes","logicalType":"decimal","precision":10,"scale":3}}]}"#; +const UUID_SCHEMA: &str = r#"{"type":"record","name":"UuidRec","fields":[{"name":"field1","type":{"type":"string","logicalType":"uuid"}}]}"#; +const FIXED_SCHEMA: &str = r#"{"type":"record","name":"FixRec","fields":[{"name":"field1","type":{"type":"fixed","name":"Fixed16","size":16}}]}"#; +const INTERVAL_SCHEMA_ENCODE: &str = r#"{"type":"record","name":"DurRecEnc","fields":[{"name":"field1","type":{"type":"fixed","name":"Duration12","size":12}}]}"#; +const INTERVAL_SCHEMA: &str = r#"{"type":"record","name":"DurRec","fields":[{"name":"field1","type":{"type":"fixed","name":"Duration12","size":12,"logicalType":"duration"}}]}"#; +const ENUM_SCHEMA: &str = r#"{"type":"record","name":"EnumRec","fields":[{"name":"field1","type":{"type":"enum","name":"MyEnum","symbols":["A","B","C"]}}]}"#; +const MIX_SCHEMA: &str = r#"{"type":"record","name":"MixRec","fields":[{"name":"f1","type":"int"},{"name":"f2","type":"long"},{"name":"f3","type":"string"},{"name":"f4","type":"double"}]}"#; +const NEST_SCHEMA: &str = r#"{"type":"record","name":"NestRec","fields":[{"name":"sub","type":{"type":"record","name":"Sub","fields":[{"name":"x","type":"int"},{"name":"y","type":"string"}]}}]}"#; + +macro_rules! dataset { + ($name:ident, $schema_json:expr, $gen_fn:ident) => { + static $name: Lazy<Vec<Vec<u8>>> = Lazy::new(|| { + let schema = + ApacheSchema::parse_str($schema_json).expect("invalid schema for generator"); + SIZES.iter().map(|&n| $gen_fn(&schema, n)).collect() + }); + }; +} + +dataset!(INT_DATA, INT_SCHEMA, gen_int); +dataset!(LONG_DATA, LONG_SCHEMA, gen_long); +dataset!(FLOAT_DATA, FLOAT_SCHEMA, gen_float); +dataset!(BOOL_DATA, BOOL_SCHEMA, gen_bool); +dataset!(DOUBLE_DATA, DOUBLE_SCHEMA, gen_double); +dataset!(BYTES_DATA, BYTES_SCHEMA, gen_bytes); +dataset!(STRING_DATA, STRING_SCHEMA, gen_string); +dataset!(DATE_DATA, DATE_SCHEMA, gen_date); +dataset!(TMILLIS_DATA, TMILLIS_SCHEMA, gen_timemillis); +dataset!(TMICROS_DATA, TMICROS_SCHEMA, gen_timemicros); +dataset!(TSMILLIS_DATA, TSMILLIS_SCHEMA, gen_ts_millis); +dataset!(TSMICROS_DATA, TSMICROS_SCHEMA, gen_ts_micros); +dataset!(MAP_DATA, MAP_SCHEMA, gen_map); +dataset!(ARRAY_DATA, ARRAY_SCHEMA, gen_array); +dataset!(DECIMAL_DATA, DECIMAL_SCHEMA, gen_decimal); +dataset!(UUID_DATA, UUID_SCHEMA, gen_uuid); +dataset!(FIXED_DATA, FIXED_SCHEMA, gen_fixed); +dataset!(INTERVAL_DATA, INTERVAL_SCHEMA_ENCODE, gen_interval); +dataset!(ENUM_DATA, ENUM_SCHEMA, gen_enum); +dataset!(MIX_DATA, MIX_SCHEMA, gen_mixed); +dataset!(NEST_DATA, NEST_SCHEMA, gen_nested); + +fn bench_scenario( + c: &mut Criterion, + name: &str, + schema_json: &'static str, + data_sets: &[Vec<u8>], + utf8view: bool, +) { + let mut group = c.benchmark_group(name); + for (idx, &rows) in SIZES.iter().enumerate() { + let datum = &data_sets[idx]; + group.throughput(Throughput::Bytes(datum.len() as u64)); + match rows { + 10_000 => { + group + .sample_size(25) + .measurement_time(Duration::from_secs(10)) + .warm_up_time(Duration::from_secs(3)); + } + 1_000_000 => { + group + .sample_size(10) + .measurement_time(Duration::from_secs(10)) + .warm_up_time(Duration::from_secs(3)); + } + _ => {} + } + group.bench_function(BenchmarkId::from_parameter(rows), |b| { + b.iter_batched_ref( + || new_decoder(schema_json, DEFAULT_BATCH, utf8view), + |decoder| { + decoder.decode(black_box(datum)).unwrap(); Review Comment: I ended up putting the `black_box` around the entire `decoder.decode` method call. This was a good catch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
