alamb commented on code in PR #8078:
URL: https://github.com/apache/arrow-rs/pull/8078#discussion_r2260213858
##########
arrow-cast/src/pretty.rs:
##########
@@ -1240,9 +1240,10 @@ mod tests {
// Pretty formatting
let opts = FormatOptions::default().with_null("null");
let opts = opts.with_duration_format(DurationFormat::Pretty);
- let pretty = pretty_format_columns_with_options("pretty",
&[array.clone()], &opts)
- .unwrap()
- .to_string();
+ let pretty =
+ pretty_format_columns_with_options("pretty",
std::slice::from_ref(&array), &opts)
Review Comment:
avoiding the clone seems good to me
##########
arrow-ipc/src/lib.rs:
##########
@@ -56,6 +56,7 @@ mod compression;
#[allow(clippy::redundant_static_lifetimes)]
#[allow(clippy::redundant_field_names)]
#[allow(non_camel_case_types)]
+#[allow(mismatched_lifetime_syntaxes)]
Review Comment:
this lint is ignored because this is all generated code
##########
parquet/src/arrow/async_writer/mod.rs:
##########
@@ -365,49 +364,6 @@ mod tests {
assert_eq!(sync_buffer, async_buffer);
}
- struct TestAsyncSink {
Review Comment:
clippy now notices this is dead code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
