alamb commented on code in PR #7972:
URL: https://github.com/apache/arrow-rs/pull/7972#discussion_r2260654032
##########
.github/actions/setup-builder/action.yaml:
##########
@@ -17,15 +17,6 @@
name: Prepare Rust Builder
description: 'Prepare Rust Build Environment'
-inputs:
Review Comment:
I removed these parameters as almost all uses installed stable
##########
.github/workflows/docs.yml:
##########
@@ -34,12 +34,8 @@ jobs:
docs:
name: Rustdocs are clean
runs-on: ubuntu-latest
- strategy:
Review Comment:
I think this is let over from a previous time when we checked docs on
different configurations -- at the moment there is a single pair that is used,
so I unparameterized this and made the version used explicit
##########
.github/workflows/arrow.yml:
##########
@@ -148,8 +148,10 @@ jobs:
submodules: true
- name: Setup Rust toolchain
uses: ./.github/actions/setup-builder
- with:
- target: wasm32-unknown-unknown,wasm32-wasip1
+ - name: Install wasm32 targets
+ run: |
+ rustup target add wasm32-unknown-unknown
Review Comment:
This adds 4 seconds to the job:
<img width="1163" height="204" alt="Screenshot 2025-08-07 at 11 19 10 AM"
src="https://github.com/user-attachments/assets/321495ff-9c6c-4123-8972-219b5e497742";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
