sdf-jkl commented on code in PR #8085:
URL: https://github.com/apache/arrow-rs/pull/8085#discussion_r2261122005
##########
parquet-variant-compute/src/cast_to_variant.rs:
##########
@@ -41,9 +41,9 @@ macro_rules! primitive_conversion {
}
/// Convert the input array to a `VariantArray` row by row, using `method`
-/// to downcast the generic array to a specific array type and `cast_fn`
-/// to transform each element to a type compatible with Variant
-macro_rules! cast_conversion {
+/// requiring a generic type to downcast the generic array to a specific
+/// array type and `cast_fn` to transform each element to a type compatible
with Variant
+macro_rules! generic_conversion {
($t:ty, $method:ident, $cast_fn:expr, $input:expr, $builder:expr) => {{
let array = $input.$method::<$t>();
Review Comment:
`::<$t>` is unnecessary for some data types during conversion, so a separate
method was created for those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
