kou commented on code in PR #47206: URL: https://github.com/apache/arrow/pull/47206#discussion_r2261968563
########## ci/scripts/r_docker_configure.sh: ########## @@ -75,5 +75,15 @@ fi # cmake is now a listed sys req. $PACKAGE_MANAGER install -y rsync cmake curl +# Update clang version to latest available +if [ "$R_UPDATE_CLANG" = true ]; then + apt update -y && + apt install -y gnupg && + curl -fsSL https://apt.llvm.org/llvm-snapshot.gpg.key | gpg --dearmor -o /etc/apt/trusted.gpg.d/llvm.gpg && + echo "deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-20 main" > /etc/apt/sources.list.d/llvm20.list && + apt update -y && Review Comment: We don't need `&&` here because we have `set -e` in this script: ```suggestion apt update -y apt install -y gnupg curl -fsSL https://apt.llvm.org/llvm-snapshot.gpg.key | gpg --dearmor -o /etc/apt/trusted.gpg.d/llvm.gpg echo "deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-20 main" > /etc/apt/sources.list.d/llvm20.list apt update -y ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
