nealrichardson commented on code in PR #47280:
URL: https://github.com/apache/arrow/pull/47280#discussion_r2262822094
##########
r/tools/nixlibs.R:
##########
@@ -336,16 +328,9 @@ determine_binary_from_stderr <- function(errs) {
lg("OpenSSL not found")
return(NULL)
} else if (any(grepl("OpenSSL version too old", errs))) {
- lg("OpenSSL found but version >= 1.0.2 is required for some features")
+ lg("OpenSSL found but version >= 3.0.0 is required for some features")
return(NULL)
# Else, determine which other binary will work
- } else if (any(grepl("Using OpenSSL version 1.0", errs))) {
- if (on_macos) {
- lg("OpenSSL 1.0 is not supported on macOS")
- return(NULL)
- }
- lg("Found libcurl and OpenSSL < 1.1")
- return("openssl-1.0")
} else if (any(grepl("Using OpenSSL version 3", errs))) {
Review Comment:
And I think you can remove this last `else if`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
