WillAyd commented on code in PR #47282:
URL: https://github.com/apache/arrow/pull/47282#discussion_r2263046241
##########
cpp/src/arrow/meson.build:
##########
@@ -423,12 +435,21 @@ arrow_lib = library(
dependencies: arrow_deps,
install: true,
gnu_symbol_visibility: 'hidden',
- cpp_shared_args: ['-DARROW_EXPORTING'],
+ c_shared_args: ['-DARROW_EXPORTING', '-DURI_LIBRARY_BUILD',
'-DURI_VISIBILITY'],
+ c_static_args: ['-DURI_STATIC_BUILD'],
+ cpp_shared_args: ['-DARROW_EXPORTING', '-DURI_LIBRARY_BUILD'],
+ cpp_static_args: ['-DARROW_STATIC'],
)
+arrow_compile_args = []
+if host_machine.system() == 'windows' and get_option('default_library') !=
'shared'
Review Comment:
I haven't gotten `default_library=both` to work yet, but haven't put a ton
of effort into debugging it either. Happy to do so after getting shared/static
support stabilized
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
