JakeDern commented on code in PR #8001:
URL: https://github.com/apache/arrow-rs/pull/8001#discussion_r2264209451
##########
arrow-ipc/src/writer.rs:
##########
@@ -363,21 +374,32 @@ impl IpcDataGenerator {
dict_id_seq,
)?;
- // It's importnat to only take the dict_id at this point,
because the dict ID
+ // It's important to only take the dict_id at this point,
because the dict ID
// sequence is assigned depth-first, so we need to first
encode children and have
// them take their assigned dict IDs before we take the dict
ID for this field.
let dict_id = dict_id_seq.next().ok_or_else(|| {
ArrowError::IpcError(format!("no dict id for field {}",
field.name()))
})?;
- let emit = dictionary_tracker.insert(dict_id, column)?;
-
- if emit {
- encoded_dictionaries.push(self.dictionary_batch_to_bytes(
- dict_id,
- dict_values,
- write_options,
- )?);
+ let compute_delta = write_options.dictionary_handling ==
DictionaryHandling::Delta;
+ match dictionary_tracker.insert(dict_id, column,
compute_delta)? {
Review Comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
