namitkewat commented on code in PR #799:
URL: https://github.com/apache/arrow-nanoarrow/pull/799#discussion_r2265241159
##########
src/nanoarrow/common/inline_array.h:
##########
@@ -302,24 +303,27 @@ static inline ArrowErrorCode
_ArrowArrayAppendEmptyInternal(struct ArrowArray* a
size_bytes);
}
- // Skip the data buffer
+ // Skip the data buffer in the next iteration
i++;
- continue;
+ break;
+
case NANOARROW_BUFFER_TYPE_DATA:
// Zero out the next bit of memory
if (private_data->layout.element_size_bits[i] % 8 == 0) {
NANOARROW_RETURN_NOT_OK(ArrowBufferAppendFill(buffer, 0, size_bytes
* n));
} else {
NANOARROW_RETURN_NOT_OK(_ArrowArrayAppendBits(array, i, 0, n));
}
- continue;
+ break;
+
case NANOARROW_BUFFER_TYPE_VIEW_OFFSET:
NANOARROW_RETURN_NOT_OK(ArrowBufferReserve(buffer, size_bytes * n));
NANOARROW_RETURN_NOT_OK(ArrowBufferAppendFill(buffer, 0, size_bytes *
n));
- continue;
+ break;
+
Review Comment:
Hi @paleolimbot
Thanks for the review!
I've reverted the changes related to comments, as improving them can be
handled in a separate pull request.
This commit now only contains the required fix of replacing `continue` with
`break`.
The PR is ready for another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
