amoeba commented on code in PR #3252: URL: https://github.com/apache/arrow-adbc/pull/3252#discussion_r2268019498
########## rust/driver_manager/src/lib.rs: ########## @@ -1753,6 +1753,18 @@ fn user_config_dir() -> Option<PathBuf> { } } +fn system_config_dir() -> Option<PathBuf> { + #[cfg(target_os = "macos")] + { + Some(PathBuf::from("/Library/Application Support/ADBC")) + } + + #[cfg(all(unix, not(target_os = "macos")))] + { + Some(PathBuf::from("/etc/adbc")) + } Review Comment: I think you're right. I didn't test but this would be a compilation error on targets like Windows and WASM right? I'll fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org