jecsand838 commented on code in PR #8047:
URL: https://github.com/apache/arrow-rs/pull/8047#discussion_r2268095142
##########
arrow-avro/src/codec.rs:
##########
@@ -909,6 +1139,21 @@ mod tests {
}
}
+ #[test]
Review Comment:
@alamb That's a good callout. I was trying to mindful of this PR's size and
most of the tests I wrote are e2e tests. I probably should have included more
tests in this PR though.
I went ahead and pushed up another 9 unit tests in `codec.rs` covering all
promotion resolution paths. I also wired up the schema resolution path to
`arrow-avro/src/reader/mod.rs` and updated the `schema_store` and
`handle_prefix` tests to have valid promotion paths to give us extra coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
