zanmato1984 commented on code in PR #47297:
URL: https://github.com/apache/arrow/pull/47297#discussion_r2268280783
##########
cpp/src/arrow/compute/kernel.cc:
##########
@@ -475,23 +475,78 @@ std::string OutputType::ToString() const {
return "computed";
}
+// ----------------------------------------------------------------------
+// MatchConstraint
+
+std::shared_ptr<MatchConstraint> DecimalsHaveSameScale() {
+ class DecimalsHaveSameScaleConstraint : public MatchConstraint {
+ public:
+ bool Matches(const std::vector<TypeHolder>& types) const override {
+ DCHECK_GE(types.size(), 2);
+ DCHECK(std::all_of(types.begin(), types.end(),
+ [](const TypeHolder& type) { return
is_decimal(type.id()); }));
+ auto ty0 = checked_cast<const DecimalType*>(types[0].type);
+ DCHECK_NE(ty0, nullptr);
Review Comment:
For debug build, `checked_cast` leverages `dynamic_cast` and may return
`nullptr` for pointer type.
Maybe what you really meant is that we use `checked_cast` on reference type?
That does eliminate the need for doing null check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
