zeroshade commented on code in PR #466:
URL: https://github.com/apache/arrow-go/pull/466#discussion_r2270446235
##########
arrow/record.go:
##########
@@ -37,13 +37,18 @@ type Record interface {
Columns() []Array
Column(i int) Array
ColumnName(i int) string
- SetColumn(i int, col Array) (Record, error)
+ SetColumn(i int, col Array) (RecordBatch, error)
// NewSlice constructs a zero-copy slice of the record with the
indicated
// indices i and j, corresponding to array[i:j].
// The returned record must be Release()'d after use.
//
// NewSlice panics if the slice is outside the valid range of the
record array.
// NewSlice panics if j < i.
- NewSlice(i, j int64) Record
+ NewSlice(i, j int64) RecordBatch
}
+
+// Deprecated: Record is deprecated, use RecordBatch instead.
+// Record represents a single row, but this type actually represents a batch
of rows.
+// This alias is provided for backwards compatibility.
Review Comment:
the convention for Go would be for the `deprecated` notice to be at the
bottom. i.e.
```suggestion
// Record as a term typically refers to a single row, but this type
represents a batch of rows, known in Arrow parlance
// as a RecordBatch. This alias is provided for backwards compatibility.
//
// Deprecated: This is deprecated to avoid the confusion of the terminology
where Record refers to a single row,
// use [RecordBatch] instead.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
