toddmeng-db commented on code in PR #3256:
URL: https://github.com/apache/arrow-adbc/pull/3256#discussion_r2271357859


##########
csharp/src/Drivers/Databricks/Reader/BaseDatabricksReader.cs:
##########
@@ -44,8 +48,19 @@ protected BaseDatabricksReader(IHiveServer2Statement 
statement, Schema schema, b
 

Review Comment:
   Actually, it might be better if it's in DatabricksCompositeReader? 
DatabricksCompositeReader doesn't inherit from BaseDatabricksReader (sorry I 
know that's a bit confusing, probably needs a rename), and better represents 
the stream's lifecycle. It's possible the BaseDatabricksReader (activeReader) 
owned by DatabricksCompositeReader is not yet initialized when 
DatabricksCompositeReader is initialized.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to