liamzwbao commented on code in PR #8101:
URL: https://github.com/apache/arrow-rs/pull/8101#discussion_r2271722983
##########
parquet-variant-compute/src/cast_to_variant.rs:
##########
@@ -148,6 +174,50 @@ pub fn cast_to_variant(input: &dyn Array) ->
Result<VariantArray, ArrowError> {
DataType::Float64 => {
primitive_conversion!(Float64Type, input, builder);
}
+ DataType::Decimal32(_, scale) => {
+ cast_conversion!(
+ Decimal32Type,
+ as_primitive,
+ |v| decimal_to_variant_decimal!(v, scale, i32,
VariantDecimal4),
+ input,
+ builder
+ );
+ }
+ DataType::Decimal64(_, scale) => {
+ cast_conversion!(
+ Decimal64Type,
+ as_primitive,
+ |v| decimal_to_variant_decimal!(v, scale, i64,
VariantDecimal8),
+ input,
+ builder
+ );
+ }
+ DataType::Decimal128(_, scale) => {
+ cast_conversion!(
+ Decimal128Type,
+ as_primitive,
+ |v| decimal_to_variant_decimal!(v, scale, i128,
VariantDecimal16),
+ input,
+ builder
+ );
+ }
+ DataType::Decimal256(_, scale) => {
+ cast_conversion!(
+ Decimal256Type,
+ as_primitive,
+ |v: i256| {
+ // Since `i128::MAX` is larger than the max value of
`VariantDecimal16`,
Review Comment:
Improved the comments to make it clearer. What I was trying to say here is
that if an `i256` cannot fit into `i128`, then it can not fit into
`VariantDecimal16 ` either.
So here we can first convert `i256` to `i128` and process it like `i128`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
