etseidl commented on code in PR #8111:
URL: https://github.com/apache/arrow-rs/pull/8111#discussion_r2274364976
##########
parquet/src/file/metadata/reader.rs:
##########
@@ -1102,10 +1218,388 @@ fn get_file_decryptor(
}
}
+// temp structs used to construct RowGroupMetaData
+thrift_struct!(
+struct RowGroup<'a> {
+ 1: required list<'a><ColumnChunk> columns
+ 2: required i64 total_byte_size
+ 3: required i64 num_rows
+ 4: optional list<SortingColumn> sorting_columns
+ 5: optional i64 file_offset
+ // we don't expose total_compressed_size so skip
+ //6: optional i64 total_compressed_size
+ 7: optional i16 ordinal
+}
+);
+
+#[cfg(feature = "encryption")]
Review Comment:
Yes, I want to consolidate at some point...I'm just not sure where it should
live. There's `basic` already for the low level enums and unions, with structs
scattered about where they're used. Pulling them all into a single module (or
maybe two) is a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
