JakeDern commented on PR #462: URL: https://github.com/apache/arrow-rs-object-store/pull/462#issuecomment-3186411496
@tustvold I have a pretty complete implementation here. Other than more docs and bits of cleanup along those lines, the last major bit I haven't accounted for is the [Rsa key stuff](https://github.com/apache/arrow-rs-object-store/blob/94c25d2dea15d2a7154bb166ae58cbf9452ebcd9/src/gcp/credential.rs#L125C1-L126C1) for GCP credentials. This is (today) specific to GCP and appears at first glance to be quite a bit more complicated to put into an object safe trait due to the requirement to create an intermediate `RsaKeyPair` equivalent type that you can then re-use. I'm assuming we'd want to also encapsulate that into the trait, but I just want to raise it for discussion. Maybe there's a straightforward way to do this that I don't know, I only have a few months experience with rust. Usually I'd have something in the interface that returns `impl MyRsaKeyPairTrait` that I could hold the library specific state in, but of course that won't be object safe anymore. Let me know what your thoughts are and thanks again for working with me on this! I know it's a lot of mental overhead, so I appreciate it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
