Re: [PR] [Variant]: Implement DataType::Interval support for cast_to_variant kernel [arrow-rs]

[via GitHub]

codephage2020 commented on code in PR #8125:
URL: https://github.com/apache/arrow-rs/pull/8125#discussion_r2275087407


##########
parquet-variant-compute/src/cast_to_variant.rs:
##########
@@ -482,6 +539,111 @@ mod tests {
         )
     }
 
+    #[test]
+    fn test_cast_to_variant_interval_year_month() {
+        run_test(
+            Arc::new(IntervalYearMonthArray::from(vec![
+                Some(0),
+                None,
+                Some(12), // 1 year
+                Some(-6), // -6 months
+                Some(i32::MAX),
+                Some(i32::MIN),
+            ])),
+            vec![
+                Some(Variant::Int32(0)),

Review Comment:
   You're right. I think throwing an InvalidArgument error is the better 
choice. 
   It's more honest and prevents silent data corruption or misinterpretation.
   
   Let's modify it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org