kou commented on code in PR #47041: URL: https://github.com/apache/arrow/pull/47041#discussion_r2275248409
########## cpp/subprojects/rapidjson.wrap: ########## @@ -16,15 +16,12 @@ # under the License. [wrap-file] -directory = rapidjson-1.1.0 -source_url = https://github.com/Tencent/rapidjson/archive/v1.1.0.tar.gz -source_filename = rapidjson-1.1.0.tar.gz -source_hash = bf7ced29704a1e696fbccf2a2b4ea068e7774fa37f6d7dd4039d0787f8bed98e -patch_filename = rapidjson_1.1.0-2_patch.zip -patch_url = https://wrapdb.mesonbuild.com/v2/rapidjson_1.1.0-2/get_patch -patch_hash = c1480d0ecef09dbaa4b4d85d86090205386fb2c7e87f4f158b20dbbda14c9afc -source_fallback_url = https://github.com/mesonbuild/wrapdb/releases/download/rapidjson_1.1.0-2/rapidjson-1.1.0.tar.gz -wrapdb_version = 1.1.0-2 +directory = rapidjson-232389d4f1012dddec4ef84861face2d2ba85709 +source_url = https://github.com/miloyip/rapidjson/archive/232389d4f1012dddec4ef84861face2d2ba85709.tar.gz Review Comment: ```suggestion source_url = https://github.com/Tencent/rapidjson/archive/232389d4f1012dddec4ef84861face2d2ba85709.tar.gz ``` ########## cpp/src/arrow/meson.build: ########## @@ -293,7 +293,8 @@ if needs_csv endif if needs_json or needs_integration - rapidjson_dep = dependency('rapidjson', include_type: 'system') + rapidjson_proj = subproject('rapidjson') + rapidjson_dep = rapidjson_proj.get_variable('rapidjson_dep') Review Comment: Hmm. I think that most distributions such as Debian, Ubuntu, AlmaLinux and conda ships patched RapidJSON. So we can use system RapidJSON in most distributions. I think that it's a problem that the current Meson configuration doesn't detect system RapidJSON: https://github.com/apache/arrow/pull/47318#issuecomment-3186600418 Anyway, let's use this approach. Because this will be removed sooner or later. We'll migrate to simdjson: https://github.com/apache/arrow/issues/35460 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
