Copilot commented on code in PR #47333:
URL: https://github.com/apache/arrow/pull/47333#discussion_r2276589771
##########
cpp/src/arrow/compute/expression.cc:
##########
@@ -795,8 +795,7 @@ Result<Datum> ExecuteScalarExpression(const Expression&
expr, const ExecBatch& i
RETURN_NOT_OK(executor->Init(&kernel_context, {kernel, types, options}));
compute::detail::DatumAccumulator listener;
- RETURN_NOT_OK(
- executor->Execute(ExecBatch(std::move(arguments), input_length),
&listener));
+ RETURN_NOT_OK(executor->Execute(ExecBatch(arguments, input_length),
&listener));
Review Comment:
Good fix. The previous use of std::move(arguments) would invalidate the
arguments vector before line 799 where executor->WrapResults(arguments, ...)
tries to use it, causing undefined behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
